-
Notifications
You must be signed in to change notification settings - Fork 338
feat: enable customization of OPA policy file path #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+39
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc89491
to
34a1b93
Compare
motou
reviewed
Oct 2, 2025
68af134
to
8427592
Compare
motou
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
Co-authored-by: Zhen Wang <motou77@gmail.com> Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>
8427592
to
1178027
Compare
- Add proper quoting to shell variables in run-server.sh to prevent word splitting and globbing issues (SC2086) - Add missing is_running() method to MockStdio in test_concurrent_requests to match StdIOEndpoint interface - Remove trailing whitespace from .env.template Fixes test failure: test_concurrent_requests AttributeError Addresses shellcheck warnings in run-server.sh Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
crivetimihai
approved these changes
Oct 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for configuring the OPA policy file path and related settings via environment variables, making the OPA server and plugin easier to customize in different deployment environments.
Changes
plugins/external/opa/README.md
policy.rego
).plugins/external/opa/opaserver/rego/policy.rego
policy.rego
) as the default.plugins/external/opa/run-server.sh
POLICY_PATH
env var when launching the OPA server.Summary